Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f90472c authored by Sara Sharon's avatar Sara Sharon Committed by Luca Coelho
Browse files

iwlwifi: mvm: fix reorder buffer for 9000 devices 



The condition to check if reorder buffer ran out of
space is faulty, as it takes into account only the
NSSN.
In case the head SN was too far behind the reorder
buffer should move forward, regardless of the NSSN
status.
This caused the driver to release packets out of order
in some scenarios.

Fixes: b915c101 ("iwlwifi: mvm: add reorder buffer per queue")
Signed-off-by: default avatarSara Sharon <sara.sharon@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent d460f1fb

drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

+4 −3
Original line number Original line Diff line number Diff line
@@ -672,11 +672,12 @@ static bool iwl_mvm_reorder(struct iwl_mvm *mvm, 
	 * If there was a significant jump in the nssn - adjust.

	 * If there was a significant jump in the nssn - adjust.

	 * If the SN is smaller than the NSSN it might need to first go into

	 * If the SN is smaller than the NSSN it might need to first go into

	 * the reorder buffer, in which case we just release up to it and the

	 * the reorder buffer, in which case we just release up to it and the

	 * rest of the function will take of storing it and releasing up to the

	 * rest of the function will take care of storing it and releasing up to

	 * nssn

	 * the nssn

	 */

	 */

	if (!iwl_mvm_is_sn_less(nssn, buffer->head_sn + buffer->buf_size,

	if (!iwl_mvm_is_sn_less(nssn, buffer->head_sn + buffer->buf_size,

				buffer->buf_size)) {

				buffer->buf_size) ||

	    !ieee80211_sn_less(sn, buffer->head_sn + buffer->buf_size)) {

		u16 min_sn = ieee80211_sn_less(sn, nssn) ? sn : nssn;

		u16 min_sn = ieee80211_sn_less(sn, nssn) ? sn : nssn;





		iwl_mvm_release_frames(mvm, sta, napi, buffer, min_sn);

		iwl_mvm_release_frames(mvm, sta, napi, buffer, min_sn);