Commit 5d19c619 authored Jan 14, 2016 by Markus Elfring Committed by David S. Miller Jan 14, 2016

fsl/fman: Delete one function call "put_device" in dtsec_config()



The Coccinelle semantic patch script "deref_null.cocci" pointed a problem
out in the implementation of the function "dtsec_config".

A null pointer was assigned to the data structure member "tbiphy" of the
variable "dtsec" if a matching device was not found.
A call of the function "put_device" was unnecessary then because
a previous call of the function "get_device" was not triggered.
Thus remove the function call "put_device" after the printing of the
desired error message.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 701a0fd5

drivers/net/ethernet/freescale/fman/fman_dtsec.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1434,7 +1434,6 @@ struct fman_mac dtsec_config(struct fman_mac_params params)
		dtsec->tbiphy = of_phy_find_device(params->internal_phy_node);
		if (!dtsec->tbiphy) {
		pr_err("of_phy_find_device (TBI PHY) failed\n");
		put_device(&dtsec->tbiphy->mdio.dev);
		goto err_dtsec_drv_param;
		}