Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5cc2b17e authored by Filipe Manana's avatar Filipe Manana Committed by Chris Mason
Browse files

Btrfs: send, add missing check for dead clone root 



After we locked the root's root item, a concurrent snapshot deletion
call might have set the dead flag on it. So check if the dead flag
is set and abort if it is, just like we do for the parent root.

Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.cz>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent 4f764e51

fs/btrfs/send.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -5855,7 +5855,8 @@ long btrfs_ioctl_send(struct file *mnt_file, void __user *arg_) 
			clone_sources_to_rollback = i + 1;

			clone_sources_to_rollback = i + 1;

			spin_lock(&clone_root->root_item_lock);

			spin_lock(&clone_root->root_item_lock);

			clone_root->send_in_progress++;

			clone_root->send_in_progress++;

			if (!btrfs_root_readonly(clone_root)) {

			if (!btrfs_root_readonly(clone_root) ||

			    btrfs_root_dead(clone_root)) {

				spin_unlock(&clone_root->root_item_lock);

				spin_unlock(&clone_root->root_item_lock);

				srcu_read_unlock(&fs_info->subvol_srcu, index);

				srcu_read_unlock(&fs_info->subvol_srcu, index);

				ret = -EPERM;

				ret = -EPERM;