Commit 5c5fa1f4 authored Jul 18, 2016 by Florian Fainelli Committed by Kalle Valo Jul 19, 2016

brcmsmac: Free packet if dma_mapping_error() fails in dma_rxfill



In case dma_mapping_error() returns an error in dma_rxfill, we would be
leaking a packet that we allocated with brcmu_pkt_buf_get_skb().

Reported-by: coverity (CID 1081819)
Fixes: 67d0cf50 ("brcmsmac: Fix WARNING caused by lack of calls to dma_mapping_error()")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 3bdae810

drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1079,8 +1079,10 @@ bool dma_rxfill(struct dma_pub *pub)

	pa = dma_map_single(di->dmadev, p->data, di->rxbufsize,		pa = dma_map_single(di->dmadev, p->data, di->rxbufsize,
	DMA_FROM_DEVICE);		DMA_FROM_DEVICE);
	if (dma_mapping_error(di->dmadev, pa))		if (dma_mapping_error(di->dmadev, pa)) {
			brcmu_pkt_buf_free_skb(p);
	return false;		return false;
			}

	/* save the free packet pointer */		/* save the free packet pointer */
	di->rxp[rxout] = p;		di->rxp[rxout] = p;