Commit 5c537408 authored Apr 11, 2006 by Brent Cook Committed by Jeff Garzik Apr 12, 2006

[PATCH] mv643xx_eth: Always free completed tx descs on tx interrupt



Fix the tx interrupt handler to free completed tx descriptors even
when NAPI is enabled.  Otherwise, the tx queue would fill up resulting
in poor performance and "NETDEV WATCHDOG: <iface>: transmit timed out"
messages.

Signed-off-by: Brent Cook <bcook@bpointsys.com>
Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent e19360f2

drivers/net/mv643xx_eth.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -552,9 +552,9 @@ static irqreturn_t mv643xx_eth_int_handler(int irq, void *dev_id,
		#else
		if (eth_int_cause & ETH_INT_CAUSE_RX)
		mv643xx_eth_receive_queue(dev, INT_MAX);
		#endif
		if (eth_int_cause_ext & ETH_INT_CAUSE_TX)
		mv643xx_eth_free_completed_tx_descs(dev);
		#endif

		/*
		* If no real interrupt occured, exit.