Commit 5b8d8fb0 authored Dec 21, 2015 by Linus Walleij

gpio: davinci: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 1f66adfb

drivers/gpio/gpio-davinci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -125,7 +125,7 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
		struct davinci_gpio_controller *d = chip2controller(chip);
		struct davinci_gpio_regs __iomem *g = d->regs;

		return (1 << offset) & readl_relaxed(&g->in_data);
		return !!((1 << offset) & readl_relaxed(&g->in_data));
		}

		/*