Commit 5b189201 authored Jan 08, 2018 by Johan Hovold Committed by Dmitry Torokhov Jan 08, 2018

Input: twl4030-vibra - fix sibling-node lookup



A helper purported to look up a child node based on its name was using
the wrong of-helper and ended up prematurely freeing the parent of-node
while searching the whole device tree depth-first starting at the parent
node.

Fixes: 64b9e4d8 ("input: twl4030-vibra: Support for DT booted kernel")
Fixes: e661d0a0 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning")
Cc: stable <stable@vger.kernel.org>     # 3.7
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 02a0d921

drivers/input/misc/twl4030-vibra.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -178,12 +178,14 @@ static SIMPLE_DEV_PM_OPS(twl4030_vibra_pm_ops,
		twl4030_vibra_suspend, twl4030_vibra_resume);

		static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
		struct device_node *node)
		struct device_node *parent)
		{
		struct device_node *node;

		if (pdata && pdata->coexist)
		return true;

		node = of_find_node_by_name(node, "codec");
		node = of_get_child_by_name(parent, "codec");
		if (node) {
		of_node_put(node);
		return true;