Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5af52b51 authored by Stephane Eranian's avatar Stephane Eranian Committed by Arnaldo Carvalho de Melo
Browse files

perf stat: add perf stat -B to pretty print large numbers 



It is hard to read very large numbers so provide an option to perf stat
to separate thousands using a separator. The patch leverages the locale
support of stdio. You need to set your LC_NUMERIC appropriately, for
instance LC_NUMERIC=en_US.UTF8. You need to pass -B to activate this
feature. This way existing scripts parsing the output do not need to be
changed. Here is an example.

$ perf stat noploop 2
noploop for 2 seconds

 Performance counter stats for 'noploop 2':

        1998.347031  task-clock-msecs         #      0.998 CPUs
                 61  context-switches         #      0.000 M/sec
                  0  CPU-migrations           #      0.000 M/sec
                118  page-faults              #      0.000 M/sec
      4,138,410,900  cycles                   #   2070.917 M/sec  (scaled from 70.01%)
      2,062,650,268  instructions             #      0.498 IPC    (scaled from 70.01%)
      2,057,653,466  branches                 #   1029.678 M/sec  (scaled from 70.01%)
             40,267  branch-misses            #      0.002 %      (scaled from 30.04%)
      2,055,961,348  cache-references         #   1028.831 M/sec  (scaled from 30.03%)
             53,725  cache-misses             #      0.027 M/sec  (scaled from 30.02%)

        2.001393933  seconds time elapsed

$ perf stat -B  noploop 2
noploop for 2 seconds

 Performance counter stats for 'noploop 2':

        1998.297883  task-clock-msecs         #      0.998 CPUs
                 59  context-switches         #      0.000 M/sec
                  0  CPU-migrations           #      0.000 M/sec
                119  page-faults              #      0.000 M/sec
      4,131,380,160  cycles                   #   2067.450 M/sec  (scaled from 70.01%)
      2,059,096,507  instructions             #      0.498 IPC    (scaled from 70.01%)
      2,054,681,303  branches                 #   1028.216 M/sec  (scaled from 70.01%)
             25,650  branch-misses            #      0.001 %      (scaled from 30.05%)
      2,056,283,014  cache-references         #   1029.017 M/sec  (scaled from 30.03%)
             47,097  cache-misses             #      0.024 M/sec  (scaled from 30.02%)

        2.001391016  seconds time elapsed

Cc: David S. Miller <davem@davemloft.net>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <4bf28fe8.914ed80a.01ca.fffff5f5@mx.google.com>
Signed-off-by: default avatarStephane Eranian <eranian@google.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent a13c3afd

tools/perf/Documentation/perf-stat.txt

+3 −0
Original line number Diff line number Diff line
@@ -43,6 +43,9 @@ OPTIONS 
-c::

        scale counter values



-B::

        print large numbers with thousands' separators according to locale



EXAMPLES

--------

tools/perf/builtin-stat.c

+14 −4
Original line number Diff line number Diff line
@@ -50,6 +50,7 @@ 


#include <sys/prctl.h>

#include <math.h>

#include <locale.h>



static struct perf_event_attr default_attrs[] = {
@@ -80,6 +81,8 @@ static pid_t *all_tids = NULL; 
static int			thread_num			=  0;

static pid_t			child_pid			= -1;

static bool			null_run			=  false;

static bool			big_num				=  false;





static int			*fd[MAX_NR_CPUS][MAX_COUNTERS];
@@ -377,7 +380,7 @@ static void nsec_printout(int counter, double avg) 
{

	double msecs = avg / 1e6;



	fprintf(stderr, " %14.6f  %-24s", msecs, event_name(counter));

	fprintf(stderr, " %18.6f  %-24s", msecs, event_name(counter));



	if (MATCH_EVENT(SOFTWARE, SW_TASK_CLOCK, counter)) {

		fprintf(stderr, " # %10.3f CPUs ",
@@ -389,7 +392,10 @@ static void abs_printout(int counter, double avg) 
{

	double total, ratio = 0.0;



	fprintf(stderr, " %14.0f  %-24s", avg, event_name(counter));

	if (big_num)

		fprintf(stderr, " %'18.0f  %-24s", avg, event_name(counter));

	else

		fprintf(stderr, " %18.0f  %-24s", avg, event_name(counter));



	if (MATCH_EVENT(HARDWARE, HW_INSTRUCTIONS, counter)) {

		total = avg_stats(&runtime_cycles_stats);
@@ -426,7 +432,7 @@ static void print_counter(int counter) 
	int scaled = event_scaled[counter];



	if (scaled == -1) {

		fprintf(stderr, " %14s  %-24s\n",

		fprintf(stderr, " %18s  %-24s\n",

			"<not counted>", event_name(counter));

		return;

	}
@@ -477,7 +483,7 @@ static void print_stat(int argc, const char **argv) 
		print_counter(counter);



	fprintf(stderr, "\n");

	fprintf(stderr, " %14.9f  seconds time elapsed",

	fprintf(stderr, " %18.9f  seconds time elapsed",

			avg_stats(&walltime_nsecs_stats)/1e9);

	if (run_count > 1) {

		fprintf(stderr, "   ( +- %7.3f%% )",
@@ -534,6 +540,8 @@ static const struct option options[] = { 
		    "repeat command and print average + stddev (max: 100)"),

	OPT_BOOLEAN('n', "null", &null_run,

		    "null run - dont start any counters"),

	OPT_BOOLEAN('B', "big-num", &big_num,

		    "print large numbers with thousands\' separators"),

	OPT_END()

};
@@ -542,6 +550,8 @@ int cmd_stat(int argc, const char **argv, const char *prefix __used) 
	int status;

	int i,j;



	setlocale(LC_ALL, "");



	argc = parse_options(argc, argv, options, stat_usage,

		PARSE_OPT_STOP_AT_NON_OPTION);

	if (!argc && target_pid == -1 && target_tid == -1)