Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5aba2ba5 authored by Sabrina Dubroca's avatar Sabrina Dubroca Committed by David S. Miller
Browse files

macsec: fix memory leaks when skb_to_sgvec fails 



Fixes: cda7ea69 ("macsec: check return value of skb_to_sgvec always")
Signed-off-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c0576e39

drivers/net/macsec.c

+2 −0
Original line number Diff line number Diff line
@@ -742,6 +742,7 @@ static struct sk_buff *macsec_encrypt(struct sk_buff *skb, 
	sg_init_table(sg, ret);

	ret = skb_to_sgvec(skb, sg, 0, skb->len);

	if (unlikely(ret < 0)) {

		aead_request_free(req);

		macsec_txsa_put(tx_sa);

		kfree_skb(skb);

		return ERR_PTR(ret);
@@ -954,6 +955,7 @@ static struct sk_buff *macsec_decrypt(struct sk_buff *skb, 
	sg_init_table(sg, ret);

	ret = skb_to_sgvec(skb, sg, 0, skb->len);

	if (unlikely(ret < 0)) {

		aead_request_free(req);

		kfree_skb(skb);

		return ERR_PTR(ret);

	}