Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a202efe authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman
Browse files

greybus: es1: create svc connection early enough 



The svc connection needs to be ready before creating the URBs, otherwise
the svc version request might come in before the AP was ready to parse
them.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 4bc88276

drivers/staging/greybus/es1.c

+6 −6
Original line number Diff line number Diff line
@@ -563,6 +563,12 @@ static int ap_probe(struct usb_interface *interface, 
		return PTR_ERR(hd);

	}



	/* Initialize AP's greybus interface */

	if (!gb_ap_svc_connection_create(hd)) {

		retval = -EINVAL;

		goto error;

	}



	es1 = hd_to_es1(hd);

	es1->hd = hd;

	es1->usb_intf = interface;
@@ -632,12 +638,6 @@ static int ap_probe(struct usb_interface *interface, 
		es1->cport_out_urb_busy[i] = false;	/* just to be anal */

	}



	/* Initialize AP's greybus interface */

	if (!gb_ap_svc_connection_create(hd)) {

		retval = -EINVAL;

		goto error;

	}



	apb1_log_enable_dentry = debugfs_create_file("apb1_log_enable",

							(S_IWUSR | S_IRUGO),

							gb_debugfs_get(), es1,

drivers/staging/greybus/es2.c

+6 −6
Original line number Diff line number Diff line
@@ -663,6 +663,12 @@ static int ap_probe(struct usb_interface *interface, 
		return PTR_ERR(hd);

	}



	/* Initialize AP's greybus interface */

	if (!gb_ap_svc_connection_create(hd)) {

		retval = -EINVAL;

		goto error;

	}



	es1 = hd_to_es1(hd);

	es1->hd = hd;

	es1->usb_intf = interface;
@@ -736,12 +742,6 @@ static int ap_probe(struct usb_interface *interface, 
		es1->cport_out_urb_busy[i] = false;	/* just to be anal */

	}



	/* Initialize AP's greybus interface */

	if (!gb_ap_svc_connection_create(hd)) {

		retval = -EINVAL;

		goto error;

	}



	apb1_log_enable_dentry = debugfs_create_file("apb1_log_enable",

							(S_IWUSR | S_IRUGO),

							gb_debugfs_get(), es1,