Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59c6e13e authored by James Smart's avatar James Smart Committed by Christoph Hellwig
Browse files

Remove hba lock from NVMET issue WQE. 



Unnecessary lock is taken. ring lock should be sufficient to protect the
work queue submission.

This was noticed when doing performance testing. The hbalock is not
needed to issue io to the nvme work queue.

Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
parent 4410a67a

drivers/scsi/lpfc/lpfc_nvmet.c

+0 −4
Original line number Diff line number Diff line
@@ -517,7 +517,6 @@ lpfc_nvmet_xmt_fcp_op(struct nvmet_fc_target_port *tgtport, 
		container_of(rsp, struct lpfc_nvmet_rcv_ctx, ctx.fcp_req);

	struct lpfc_hba *phba = ctxp->phba;

	struct lpfc_iocbq *nvmewqeq;

	unsigned long iflags;

	int rc, id;



#ifdef CONFIG_SCSI_LPFC_DEBUG_FS
@@ -571,10 +570,7 @@ lpfc_nvmet_xmt_fcp_op(struct nvmet_fc_target_port *tgtport, 
	lpfc_nvmeio_data(phba, "NVMET FCP CMND: xri x%x op x%x len x%x\n",

			 ctxp->oxid, rsp->op, rsp->rsplen);



	/* For now we take hbalock */

	spin_lock_irqsave(&phba->hbalock, iflags);

	rc = lpfc_sli4_issue_wqe(phba, LPFC_FCP_RING, nvmewqeq);

	spin_unlock_irqrestore(&phba->hbalock, iflags);

	if (rc == WQE_SUCCESS) {

		ctxp->flag |= LPFC_NVMET_IO_INP;

#ifdef CONFIG_SCSI_LPFC_DEBUG_FS