Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 593bc462 authored by Alexandre Bailon's avatar Alexandre Bailon Committed by Greg Kroah-Hartman
Browse files

usb: musb: musb_cppi41: Workaround DMA stall issue during teardown 



The DMA may hang up if a teardown is initiated while an endpoint is still
active (Advisory 2.3.27 of DA8xx errata).
To workaround this issue, add a delay before to initiate the teardown.

Signed-off-by: default avatarAlexandre Bailon <abailon@baylibre.com>
Signed-off-by: default avatarBin Liu <b-liu@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d6299b6e

drivers/usb/musb/da8xx.c

+1 −1
Original line number Diff line number Diff line
@@ -483,7 +483,7 @@ da8xx_dma_controller_create(struct musb *musb, void __iomem *base) 


static const struct musb_platform_ops da8xx_ops = {

	.quirks		= MUSB_INDEXED_EP | MUSB_PRESERVE_SESSION |

			  MUSB_DMA_CPPI41,

			  MUSB_DMA_CPPI41 | MUSB_DA8XX,

	.init		= da8xx_musb_init,

	.exit		= da8xx_musb_exit,

drivers/usb/musb/musb_core.h

+1 −0
Original line number Diff line number Diff line
@@ -172,6 +172,7 @@ struct musb_io; 
 */

struct musb_platform_ops {



#define MUSB_DA8XX		BIT(8)

#define MUSB_PRESERVE_SESSION	BIT(7)

#define MUSB_DMA_UX500		BIT(6)

#define MUSB_DMA_CPPI41		BIT(5)

drivers/usb/musb/musb_cppi41.c

+4 −0
Original line number Diff line number Diff line
@@ -571,6 +571,10 @@ static int cppi41_dma_channel_abort(struct dma_channel *channel) 
		}

	}



	/* DA8xx Advisory 2.3.27: wait 250 ms before to start the teardown */

	if (musb->io.quirks & MUSB_DA8XX)

		mdelay(250);



	tdbit = 1 << cppi41_channel->port_num;

	if (is_tx)

		tdbit <<= 16;