Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5935f81c authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ftgmac100: fix skb truesize underestimation 



ftgmac100 allocates a page per skb fragment. We must account
PAGE_SIZE increments on skb->truesize, not the actual frag length.

If frame is under 64 bytes, page is freed, and truesize adjusted.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
CC: Po-Yu Chuang <ratbert@faraday-tech.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7ae60b3f

drivers/net/ethernet/faraday/ftgmac100.c

+3 −1
Original line number Diff line number Diff line
@@ -467,7 +467,7 @@ static bool ftgmac100_rx_packet(struct ftgmac100 *priv, int *processed) 


		skb->len += size;

		skb->data_len += size;

		skb->truesize += size;

		skb->truesize += PAGE_SIZE;



		if (ftgmac100_rxdes_last_segment(rxdes))

			done = true;
@@ -478,6 +478,8 @@ static bool ftgmac100_rx_packet(struct ftgmac100 *priv, int *processed) 
		rxdes = ftgmac100_current_rxdes(priv);

	} while (!done);



	if (skb->len <= 64)

		skb->truesize -= PAGE_SIZE;

	__pskb_pull_tail(skb, min(skb->len, 64U));

	skb->protocol = eth_type_trans(skb, netdev);