Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 584c0059 authored by Steven Rostedt (VMware)'s avatar Steven Rostedt (VMware) Committed by Paul E. McKenney
Browse files

tracing, rcu: Remove no longer used trace event rcu_prep_idle 



Commit c0f4dfd4 ("rcu: Make RCU_FAST_NO_HZ take advantage of
numbered callbacks") removed the only instances of trace_rcu_prep_idle,
but did not remove the TRACE_EVENT() that creates it. As defined trace
events take up memory within the kernel even when they are not used,
this is a waste of space. Remove the obsolete event.

Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent 3af3999b

include/trace/events/rcu.h

+0 −40
Original line number Diff line number Diff line
@@ -457,45 +457,6 @@ TRACE_EVENT(rcu_dyntick, 
		  __entry->dynticks & 0xfff)

);



/*

 * Tracepoint for RCU preparation for idle, the goal being to get RCU

 * processing done so that the current CPU can shut off its scheduling

 * clock and enter dyntick-idle mode.  One way to accomplish this is

 * to drain all RCU callbacks from this CPU, and the other is to have

 * done everything RCU requires for the current grace period.  In this

 * latter case, the CPU will be awakened at the end of the current grace

 * period in order to process the remainder of its callbacks.

 *

 * These tracepoints take a string as argument:

 *

 *	"No callbacks": Nothing to do, no callbacks on this CPU.

 *	"In holdoff": Nothing to do, holding off after unsuccessful attempt.

 *	"Begin holdoff": Attempt failed, don't retry until next jiffy.

 *	"Dyntick with callbacks": Entering dyntick-idle despite callbacks.

 *	"Dyntick with lazy callbacks": Entering dyntick-idle w/lazy callbacks.

 *	"More callbacks": Still more callbacks, try again to clear them out.

 *	"Callbacks drained": All callbacks processed, off to dyntick idle!

 *	"Timer": Timer fired to cause CPU to continue processing callbacks.

 *	"Demigrate": Timer fired on wrong CPU, woke up correct CPU.

 *	"Cleanup after idle": Idle exited, timer canceled.

 */

TRACE_EVENT(rcu_prep_idle,



	TP_PROTO(const char *reason),



	TP_ARGS(reason),



	TP_STRUCT__entry(

		__field(const char *, reason)

	),



	TP_fast_assign(

		__entry->reason = reason;

	),



	TP_printk("%s", __entry->reason)

);



/*

 * Tracepoint for the registration of a single RCU callback function.

 * The first argument is the type of RCU, the second argument is
@@ -803,7 +764,6 @@ TRACE_EVENT(rcu_barrier, 
	while (0)

#define trace_rcu_fqs(rcuname, gpnum, cpu, qsevent) do { } while (0)

#define trace_rcu_dyntick(polarity, oldnesting, newnesting, dyntick) do { } while (0)

#define trace_rcu_prep_idle(reason) do { } while (0)

#define trace_rcu_callback(rcuname, rhp, qlen_lazy, qlen) do { } while (0)

#define trace_rcu_kfree_callback(rcuname, rhp, offset, qlen_lazy, qlen) \

	do { } while (0)