Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5803348c authored by Marc Zyngier's avatar Marc Zyngier Committed by Linus Walleij
Browse files

pinctrl/at91: Don't provide a default trigger type 



at91 used to set a default trigger type for GPIO interrupts in
order to cope with the old board files. These days are long gone,
and it all gets probed through DT.

Andras Szemzo reported that the Ethernet device on his board was
bailing to be probed, due to a conflict in interrupt trigger.
Surely enough, this is due to this default trigger still being
present, and turning this into a IRQ_TYPE_NONE fixes the issue.

Reported-by: default avatarAndras Szemzo <szemzo.andras@gmail.com>
Tested-by: default avatarAndras Szemzo <szemzo.andras@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 66cd89df

drivers/pinctrl/pinctrl-at91.c

+1 −1
Original line number Diff line number Diff line
@@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev, 
				   &gpio_irqchip,

				   0,

				   handle_edge_irq,

				   IRQ_TYPE_EDGE_BOTH);

				   IRQ_TYPE_NONE);

	if (ret) {

		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",

			at91_gpio->pioc_idx);