Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 579c49ef authored by Viresh Kumar's avatar Viresh Kumar Committed by Rafael J. Wysocki
Browse files

PM / OPP: Reword binding supporting multiple regulators per device 



On certain platforms (like TI), DVFS for a single device (CPU) requires
configuring multiple power supplies.

The OPP bindings already contains binding and example to explain this
case, but it isn't sufficient.

- There is no way for the code parsing these bindings to know which
  voltage values belong to which power supply.

- It is not possible to know the order in which the supplies need to be
  configured while switching OPPs.

This patch clarifies on those details by mentioning that such
information is left for the implementation specific bindings to explain.
They may want to hardcode such details or implement their own properties
to get such information. All implementations using multiple regulators
for their devices must provide a binding document explaining their
implementation.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Acked-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 309fe8d6

Documentation/devicetree/bindings/opp/opp.txt

+15 −6
Original line number Diff line number Diff line
@@ -86,8 +86,14 @@ Optional properties: 
  Single entry is for target voltage and three entries are for <target min max>

  voltages.



  Entries for multiple regulators must be present in the same order as

  regulators are specified in device's DT node.

  Entries for multiple regulators shall be provided in the same field separated

  by angular brackets <>. The OPP binding doesn't provide any provisions to

  relate the values to their power supplies or the order in which the supplies

  need to be configured and that is left for the implementation specific

  binding.



  Entries for all regulators shall be of the same size, i.e. either all use a

  single value or triplets.



- opp-microvolt-<name>: Named opp-microvolt property. This is exactly similar to

  the above opp-microvolt property, but allows multiple voltage ranges to be
@@ -104,10 +110,13 @@ Optional properties: 


  Should only be set if opp-microvolt is set for the OPP.



  Entries for multiple regulators must be present in the same order as

  regulators are specified in device's DT node. If this property isn't required

  for few regulators, then this should be marked as zero for them. If it isn't

  required for any regulator, then this property need not be present.

  Entries for multiple regulators shall be provided in the same field separated

  by angular brackets <>. If current values aren't required for a regulator,

  then it shall be filled with 0. If current values aren't required for any of

  the regulators, then this field is not required. The OPP binding doesn't

  provide any provisions to relate the values to their power supplies or the

  order in which the supplies need to be configured and that is left for the

  implementation specific binding.



- opp-microamp-<name>: Named opp-microamp property. Similar to

  opp-microvolt-<name> property, but for microamp instead.