Commit 578620f4 authored Dec 10, 2016 by Dan Carpenter Committed by Theodore Ts'o Dec 10, 2016

ext4: return -ENOMEM instead of success



We should set the error code if kzalloc() fails.

Fixes: 67cf5b09 ("ext4: add the basic function for inline data support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org

parent 7e6e1ef4

fs/ext4/inline.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -341,8 +341,10 @@ static int ext4_update_inline_data(handle_t handle, struct inode inode,

		len -= EXT4_MIN_INLINE_DATA_SIZE;
		value = kzalloc(len, GFP_NOFS);
		if (!value)
		if (!value) {
		error = -ENOMEM;
		goto out;
		}

		error = ext4_xattr_ibody_get(inode, i.name_index, i.name,
		value, len);