Commit 5751a24e authored Nov 17, 2017 by Joe Perches Committed by Linus Torvalds Nov 17, 2017

checkpatch: add --strict test for lines ending in [ or (

Lines that end in an open bracket or open parenthesis are generally hard
to follow. Lines following those ending with open parenthesis are also
rarely aligned to that open parenthesis.

Suggest not ending lines with '[' or '('

Link: http://lkml.kernel.org/r/8fd0b2b4a7482064254e37931eb9302a81d5aa2f.1508340786.git.joe@perches.com

Signed-off-by: Joe Perches <joe@perches.com>
Suggested-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 87bd499a

scripts/checkpatch.pl

+6 −0

Original line number	Diff line number	Diff line
		@@ -3184,6 +3184,12 @@ sub process {
		# check we are in a valid C source file if not then ignore this hunk
		next if ($realfile !~ /\.(h\|c)$/);

		# check for unusual line ending [ or (
		if ($line =~ /^\+.([\[\(])\s$/) {
		CHK("OPEN_ENDED_LINE",
		"Lines should not end with a '$1'\n" . $herecurr);
		}

		# check if this appears to be the start function declaration, save the name
		if ($sline =~ /^\+\{\s*$/ &&
		$prevline =~ /^\+(?:(?:(?:$Storage\|$Inline)\s)\s$Type\s)?($Ident)\(/) {