Commit 5737f6c9 authored Sep 19, 2016 by Jesper Dangaard Brouer Committed by David S. Miller Sep 20, 2016

mlx4: add missed recycle opportunity for XDP_TX on TX failure



Correct drop handling for XDP_TX on TX failure, were recently added in
commit 95357907 ("mlx4: fix XDP_TX is acting like XDP_PASS on TX
ring full").

The change missed an opportunity for recycling the RX page, instead of
going through the page allocator, like the regular XDP_DROP action does.
This patch cease the opportunity, by going through the XDP_DROP case.

Fixes: 95357907 ("mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1860e688

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -906,11 +906,12 @@ int mlx4_en_process_rx_cq(struct net_device dev, struct mlx4_en_cq cq, int bud
		length, tx_index,
		&doorbell_pending))
		goto consumed;
		goto next; /* Drop on xmit failure */
		goto xdp_drop; /* Drop on xmit failure */
		default:
		bpf_warn_invalid_xdp_action(act);
		case XDP_ABORTED:
		case XDP_DROP:
		xdp_drop:
		if (mlx4_en_rx_recycle(ring, frags))
		goto consumed;
		goto next;