Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56d2c61d authored by Wolfram Sang's avatar Wolfram Sang Committed by Mark Brown
Browse files

ASoC: rsnd: check return value of init function 



Currently, this function cannot fail for the ADG case. Still, let's
apply defensive programming techniques to make sure we fail gracefully
whenever rsnd_mod_init() gets extended with another failure case.
Reported by Coverity (CID 1397893).

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 34157f7b

sound/soc/sh/rcar/adg.c

+4 −1
Original line number Diff line number Diff line
@@ -564,6 +564,7 @@ int rsnd_adg_probe(struct rsnd_priv *priv) 
	struct rsnd_adg *adg;

	struct device *dev = rsnd_priv_to_dev(priv);

	struct device_node *np = dev->of_node;

	int ret;



	adg = devm_kzalloc(dev, sizeof(*adg), GFP_KERNEL);

	if (!adg) {
@@ -571,8 +572,10 @@ int rsnd_adg_probe(struct rsnd_priv *priv) 
		return -ENOMEM;

	}



	rsnd_mod_init(priv, &adg->mod, &adg_ops,

	ret = rsnd_mod_init(priv, &adg->mod, &adg_ops,

		      NULL, NULL, 0, 0);

	if (ret)

		return ret;



	rsnd_adg_get_clkin(priv, adg);

	rsnd_adg_get_clkout(priv, adg);