Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56a7f515 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] em28xx: unregister devices in case of failure 



If something bad happens during device registration, unregister
the already registered devices.

Without that, it will have lots of KASAN errors when udev
would try to open the devices.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent af7d374a

drivers/media/usb/em28xx/em28xx-video.c

+16 −0
Original line number Original line Diff line number Diff line
@@ -2579,6 +2579,22 @@ static int em28xx_v4l2_init(struct em28xx *dev) 
	return 0;

	return 0;





unregister_dev:

unregister_dev:

	if (video_is_registered(&v4l2->radio_dev)) {

		em28xx_info("V4L2 device %s deregistered\n",

			    video_device_node_name(&v4l2->radio_dev));

		video_unregister_device(&v4l2->radio_dev);

	}

	if (video_is_registered(&v4l2->vbi_dev)) {

		em28xx_info("V4L2 device %s deregistered\n",

			    video_device_node_name(&v4l2->vbi_dev));

		video_unregister_device(&v4l2->vbi_dev);

	}

	if (video_is_registered(&v4l2->vdev)) {

		em28xx_info("V4L2 device %s deregistered\n",

			    video_device_node_name(&v4l2->vdev));

		video_unregister_device(&v4l2->vdev);

	}



	v4l2_ctrl_handler_free(&v4l2->ctrl_handler);

	v4l2_ctrl_handler_free(&v4l2->ctrl_handler);

	v4l2_device_unregister(&v4l2->v4l2_dev);

	v4l2_device_unregister(&v4l2->v4l2_dev);

err:

err: