Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5685bee3 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Kalle Valo
Browse files

atmel: Replace mdelay() with msleep() in probe_atmel_card() 



probe_atmel_card() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 37a634f6

drivers/net/wireless/atmel/atmel.c

+1 −1
Original line number Diff line number Diff line
@@ -3677,7 +3677,7 @@ static int probe_atmel_card(struct net_device *dev) 
		atmel_write16(dev, GCR, 0x0060);



	atmel_write16(dev, GCR, 0x0040);

	mdelay(500);

	msleep(500);



	if (atmel_read16(dev, MR2) == 0) {

		/* No stored firmware so load a small stub which just