Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55e1f9f0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: hpsa: fix the device_id in hpsa_update_device_info() 



The parentheses are in the wrong place so we specify the length as
"sizeof(this_device->device_id) < 0" which is zero.

Fixes: 988b87edd231 ("scsi: hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 78453a31

drivers/scsi/hpsa.c

+1 −1
Original line number Diff line number Diff line
@@ -3827,7 +3827,7 @@ static int hpsa_update_device_info(struct ctlr_info *h, 
	memset(this_device->device_id, 0,

		sizeof(this_device->device_id));

	if (hpsa_get_device_id(h, scsi3addr, this_device->device_id, 8,

		sizeof(this_device->device_id) < 0))

		sizeof(this_device->device_id)) < 0)

		dev_err(&h->pdev->dev,

			"hpsa%d: %s: can't get device id for host %d:C0:T%d:L%d\t%s\t%.16s\n",

			h->ctlr, __func__,