Commit 55c95e73 authored Jun 03, 2010 by Rami Rosen Committed by David S. Miller Jun 05, 2010

fix return value of __pppoe_xmit() method.



Hi,
 __pppoe_xmit() in drivers/net/pppoe always returns 1.
When the methods fails (via goto abort), it should return 0 and not 1.

Regards,
Rami Rosen

Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5918e2fb

drivers/net/pppoe.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -949,7 +949,7 @@ static int __pppoe_xmit(struct sock sk, struct sk_buff skb)

		abort:
		kfree_skb(skb);
		return 1;
		return 0;
		}

		/************************************************************************