Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5588340d authored by Huang Ying's avatar Huang Ying Committed by Len Brown
Browse files

ACPI, APEI, GHES, Do not ratelimit fatal error printk before panic 



printk is used by GHES to report hardware errors.  Normally, the
printk will be ratelimited to avoid too many hardware error reports in
kernel log.  Because there may be thousands or even millions of
corrected hardware errors during system running.

That is different for fatal hardware error, because system will go
panic as soon as possible, there will be no more than several error
records.  And these error records are valuable for system fault
diagnosis, so they should not be ratelimited.

Signed-off-by: default avatarHuang Ying <ying.huang@intel.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent d37afc50

drivers/acpi/apei/ghes.c

+14 −11
Original line number Original line Diff line number Diff line
@@ -360,11 +360,8 @@ static void ghes_do_proc(struct ghes *ghes) 
	}

	}

}

}





static void ghes_print_estatus(const char *pfx, struct ghes *ghes)

static void __ghes_print_estatus(const char *pfx, struct ghes *ghes)

{

{

	/* Not more than 2 messages every 5 seconds */

	static DEFINE_RATELIMIT_STATE(ratelimit, 5*HZ, 2);



	if (pfx == NULL) {

	if (pfx == NULL) {

		if (ghes_severity(ghes->estatus->error_severity) <=

		if (ghes_severity(ghes->estatus->error_severity) <=

		    GHES_SEV_CORRECTED)

		    GHES_SEV_CORRECTED)
@@ -372,12 +369,18 @@ static void ghes_print_estatus(const char *pfx, struct ghes *ghes) 
		else

		else

			pfx = KERN_ERR HW_ERR;

			pfx = KERN_ERR HW_ERR;

	}

	}

	if (__ratelimit(&ratelimit)) {

	printk("%s""Hardware error from APEI Generic Hardware Error Source: %d\n",

		printk(

	"%s""Hardware error from APEI Generic Hardware Error Source: %d\n",

	       pfx, ghes->generic->header.source_id);

	       pfx, ghes->generic->header.source_id);

	apei_estatus_print(pfx, ghes->estatus);

	apei_estatus_print(pfx, ghes->estatus);

}

}



static void ghes_print_estatus(const char *pfx, struct ghes *ghes)

{

	/* Not more than 2 messages every 5 seconds */

	static DEFINE_RATELIMIT_STATE(ratelimit, 5*HZ, 2);



	if (__ratelimit(&ratelimit))

		__ghes_print_estatus(pfx, ghes);

}

}





static int ghes_proc(struct ghes *ghes)

static int ghes_proc(struct ghes *ghes)
@@ -476,7 +479,7 @@ static int ghes_notify_nmi(struct notifier_block *this, 




	if (sev_global >= GHES_SEV_PANIC) {

	if (sev_global >= GHES_SEV_PANIC) {

		oops_begin();

		oops_begin();

		ghes_print_estatus(KERN_EMERG HW_ERR, ghes_global);

		__ghes_print_estatus(KERN_EMERG HW_ERR, ghes_global);

		/* reboot to log the error! */

		/* reboot to log the error! */

		if (panic_timeout == 0)

		if (panic_timeout == 0)

			panic_timeout = ghes_panic_timeout;

			panic_timeout = ghes_panic_timeout;