Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53dfc3b9 authored by Linus Walleij's avatar Linus Walleij Committed by Jonathan Cameron
Browse files

iio: light: bh1780: return after write 



When writing a value using direct reg access from debugfs
we need to return and not fall through to reading the
value, lest we'll dereference a NULL pointer.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 04bf0217

drivers/iio/light/bh1780.c

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ static int bh1780_debugfs_reg_access(struct iio_dev *indio_dev, 
	int ret;



	if (!readval)

		bh1780_write(bh1780, (u8)reg, (u8)writeval);

		return bh1780_write(bh1780, (u8)reg, (u8)writeval);



	ret = bh1780_read(bh1780, (u8)reg);

	if (ret < 0)