Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53576d9b authored by Al Viro's avatar Al Viro Committed by David S. Miller
Browse files

[IPV4]: inetpeer annotations 



This one is interesting - we use net-endian value as search key, but
order the tree by *host-endian* comparisons of keys.  OK since we only
care about lookups.  Annotated inet_getpeer() and friends.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d878e72e

include/net/inetpeer.h

+2 −2
Original line number Diff line number Diff line
@@ -22,7 +22,7 @@ struct inet_peer 
	unsigned long		dtime;		/* the time of last use of not

						 * referenced entries */

	atomic_t		refcnt;

	__u32			v4daddr;	/* peer's address */

	__be32			v4daddr;	/* peer's address */

	__u16			avl_height;

	__u16			ip_id_count;	/* IP ID for the next packet */

	atomic_t		rid;		/* Frag reception counter */
@@ -33,7 +33,7 @@ struct inet_peer 
void			inet_initpeers(void) __init;



/* can be called with or without local BH being disabled */

struct inet_peer	*inet_getpeer(__u32 daddr, int create);

struct inet_peer	*inet_getpeer(__be32 daddr, int create);



extern spinlock_t inet_peer_unused_lock;

extern struct inet_peer **inet_peer_unused_tailp;

net/ipv4/inetpeer.c

+2 −2
Original line number Diff line number Diff line
@@ -163,7 +163,7 @@ static void unlink_from_unused(struct inet_peer *p) 
	for (u = peer_root; u != peer_avl_empty; ) {		\

		if (daddr == u->v4daddr)			\

			break;					\

		if (daddr < u->v4daddr)				\

		if ((__force __u32)daddr < (__force __u32)u->v4daddr)	\

			v = &u->avl_left;			\

		else						\

			v = &u->avl_right;			\
@@ -368,7 +368,7 @@ static int cleanup_once(unsigned long ttl) 
}



/* Called with or without local BH being disabled. */

struct inet_peer *inet_getpeer(__u32 daddr, int create)

struct inet_peer *inet_getpeer(__be32 daddr, int create)

{

	struct inet_peer *p, *n;

	struct inet_peer **stack[PEER_MAXDEPTH], ***stackptr;