Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5258830b authored by Julian Wiedmann's avatar Julian Wiedmann Committed by David S. Miller
Browse files

s390/qeth: simplify fragment type selection 



Improve readability of the code that determines a buffer element's
fragment type, and reduce the number of cases down from 5 to 3.

Signed-off-by: default avatarJulian Wiedmann <jwi@linux.vnet.ibm.com>
Acked-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 699d3fe5

drivers/s390/net/qeth_core_main.c

+8 −15
Original line number Diff line number Diff line
@@ -3918,21 +3918,14 @@ static inline void __qeth_fill_buffer(struct sk_buff *skb, 
		buffer->element[element].addr = data;

		buffer->element[element].length = length_here;

		length -= length_here;

		if (!length) {

			if (first_lap)

				if (skb_shinfo(skb)->nr_frags)

		if (first_lap) {

			if (length || skb_is_nonlinear(skb))

				/* skb needs additional elements */

				buffer->element[element].eflags =

					SBAL_EFLAGS_FIRST_FRAG;

			else

				buffer->element[element].eflags = 0;

			else

				buffer->element[element].eflags =

				    SBAL_EFLAGS_MIDDLE_FRAG;

		} else {

			if (first_lap)

				buffer->element[element].eflags =

				    SBAL_EFLAGS_FIRST_FRAG;

			else

			buffer->element[element].eflags =

				SBAL_EFLAGS_MIDDLE_FRAG;

		}