Commit 51904b08 authored Oct 22, 2014 by J. Bruce Fields

nfsd4: fix crash on unknown operation number



Unknown operation numbers are caught in nfsd4_decode_compound() which
sets op->opnum to OP_ILLEGAL and op->status to nfserr_op_illegal.  The
error causes the main loop in nfsd4_proc_compound() to skip most
processing.  But nfsd4_proc_compound also peeks ahead at the next
operation in one case and doesn't take similar precautions there.

Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent d1d84c96

fs/nfsd/nfs4proc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1272,7 +1272,8 @@ static bool need_wrongsec_check(struct svc_rqst *rqstp)
		*/
		if (argp->opcnt == resp->opcnt)
		return false;

		if (next->opnum == OP_ILLEGAL)
		return false;
		nextd = OPDESC(next);
		/*
		* Rest of 2.6.3.1.1: certain operations will return WRONGSEC