Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5160fb4b authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mauro Carvalho Chehab
Browse files

media: omap3isp: fix uninitialized variable use 



A debug printk statement was copied incorrectly into the new
csi1 parser code and causes a warning there:

drivers/media/platform/omap3isp/isp.c: In function 'isp_probe':
include/linux/dynamic_debug.h:134:3: error: 'i' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Since there is only one lane, the index is never set. This
changes the debug print to always print a zero instead,
keeping the original format of the message.

Fixes: 9211434b ("media: omap3isp: Parse CSI1 configuration from the device tree")

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 70b074df

drivers/media/platform/omap3isp/isp.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2092,7 +2092,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwnode, 
			buscfg->bus.ccp2.lanecfg.data[0].pol =

			buscfg->bus.ccp2.lanecfg.data[0].pol =

				vep.bus.mipi_csi1.lane_polarity[1];

				vep.bus.mipi_csi1.lane_polarity[1];





			dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i,

			dev_dbg(dev, "data lane polarity %u, pos %u\n",

				buscfg->bus.ccp2.lanecfg.data[0].pol,

				buscfg->bus.ccp2.lanecfg.data[0].pol,

				buscfg->bus.ccp2.lanecfg.data[0].pos);

				buscfg->bus.ccp2.lanecfg.data[0].pos);