Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 512c044a authored by Sujith Manoharan's avatar Sujith Manoharan Committed by John W. Linville
Browse files

ath9k_htc: Fix error path in URB allocation 



ath9k_hif_usb_alloc_urbs() takes care of freeing
all the allocated URBs for the various endpoints when
an error occurs. Calling ath9k_hif_usb_dealloc_urbs() would
cause a panic since the URBs have already been freed.

Signed-off-by: default avatarSujith Manoharan <Sujith.Manoharan@atheros.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 3e3f1d19

drivers/net/wireless/ath/ath9k/hif_usb.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -916,13 +916,11 @@ static int ath9k_hif_usb_dev_init(struct hif_device_usb *hif_dev, u32 drv_info) 
	if (ret) {

	if (ret) {

		dev_err(&hif_dev->udev->dev,

		dev_err(&hif_dev->udev->dev,

			"ath9k_htc: Unable to allocate URBs\n");

			"ath9k_htc: Unable to allocate URBs\n");

		goto err_urb;

		goto err_fw_download;

	}

	}





	return 0;

	return 0;





err_urb:

	ath9k_hif_usb_dealloc_urbs(hif_dev);

err_fw_download:

err_fw_download:

	release_firmware(hif_dev->firmware);

	release_firmware(hif_dev->firmware);

err_fw_req:

err_fw_req: