Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5089eaff authored by Carlos Maiolino's avatar Carlos Maiolino Committed by Darrick J. Wong
Browse files

libxfs: Fix a couple of sparse complaintis 



No significant changes, just silence a couple of sparse errors.

Using cpu_to_be32(NULLAGINO), the NULLAGINO constant will be encoded in
BE as a constant, avoiding a BE -> CPU conversion every iteraction of
the loop, if be32_to_cpu(agi->agi_unlinked[i]) was used instead.

Signed-off-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: default avatarBill O'Donnell <billodo@redhat.com>
Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
parent e4e542a6

fs/xfs/libxfs/xfs_ag_resv.h

+1 −1
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ xfs_ag_resv_rmapbt_alloc( 
	struct xfs_mount	*mp,

	xfs_agnumber_t		agno)

{

	struct xfs_alloc_arg	args = {0};

	struct xfs_alloc_arg	args = { NULL };

	struct xfs_perag	*pag;



	args.len = 1;

fs/xfs/libxfs/xfs_ialloc.c

+1 −1
Original line number Diff line number Diff line
@@ -2537,7 +2537,7 @@ xfs_agi_verify( 
		return __this_address;



	for (i = 0; i < XFS_AGI_UNLINKED_BUCKETS; i++) {

		if (agi->agi_unlinked[i] == NULLAGINO)

		if (agi->agi_unlinked[i] == cpu_to_be32(NULLAGINO))

			continue;

		if (!xfs_verify_ino(mp, be32_to_cpu(agi->agi_unlinked[i])))

			return __this_address;