Commit 50010c20 authored Oct 19, 2015 by Dan Carpenter Committed by David S. Miller Oct 21, 2015

irda: precedence bug in irlmp_seq_hb_idx()

This is decrementing the pointer, instead of the value stored in the
pointer. KASan detects it as an out of bounds reference.

Reported-by: "Berry Cheng 程君(成淼)" <chengmiao.cj@alibaba-inc.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ca88ea12

net/irda/irlmp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1839,7 +1839,7 @@ static void irlmp_seq_hb_idx(struct irlmp_iter_state iter, loff_t *off)
		for (element = hashbin_get_first(iter->hashbin);
		element != NULL;
		element = hashbin_get_next(iter->hashbin)) {
		if (!off \|\| *off-- == 0) {
		if (!off \|\| (*off)-- == 0) {
		/* NB: hashbin left locked */
		return element;
		}