Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f23c43c authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

mlxsw: core: remove unnecessary function mlxsw_core_driver_put 



The function mlxsw_core_driver_put only traverse mlxsw_core_driver_list
to find the matched mlxsw_driver,but never used it.
So it can be removed safely.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0f5c6c30

drivers/net/ethernet/mellanox/mlxsw/core.c

+0 −12
Original line number Diff line number Diff line
@@ -726,15 +726,6 @@ static struct mlxsw_driver *mlxsw_core_driver_get(const char *kind) 
	return mlxsw_driver;

}



static void mlxsw_core_driver_put(const char *kind)

{

	struct mlxsw_driver *mlxsw_driver;



	spin_lock(&mlxsw_core_driver_list_lock);

	mlxsw_driver = __driver_find(kind);

	spin_unlock(&mlxsw_core_driver_list_lock);

}



static int mlxsw_devlink_port_split(struct devlink *devlink,

				    unsigned int port_index,

				    unsigned int count,
@@ -1082,7 +1073,6 @@ int mlxsw_core_bus_device_register(const struct mlxsw_bus_info *mlxsw_bus_info, 
	if (!reload)

		devlink_free(devlink);

err_devlink_alloc:

	mlxsw_core_driver_put(device_kind);

	return err;

}

EXPORT_SYMBOL(mlxsw_core_bus_device_register);
@@ -1090,7 +1080,6 @@ EXPORT_SYMBOL(mlxsw_core_bus_device_register); 
void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,

				      bool reload)

{

	const char *device_kind = mlxsw_core->bus_info->device_kind;

	struct devlink *devlink = priv_to_devlink(mlxsw_core);



	if (mlxsw_core->reload_fail)
@@ -1111,7 +1100,6 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core, 
		return;

reload_fail:

	devlink_free(devlink);

	mlxsw_core_driver_put(device_kind);

}

EXPORT_SYMBOL(mlxsw_core_bus_device_unregister);