Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ec7ac12 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

macvlan: fix a possible use after free 



Commit bc416d97 (macvlan: handle fragmented multicast frames) added a
possible use after free in macvlan_handle_frame(), since
ip_check_defrag() uses pskb_may_pull() : skb header can be reallocated.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Cc: Ben Greear <greearb@candelatech.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f80400a2

drivers/net/macvlan.c

+1 −0
Original line number Diff line number Diff line
@@ -173,6 +173,7 @@ static rx_handler_result_t macvlan_handle_frame(struct sk_buff **pskb) 
		skb = ip_check_defrag(skb, IP_DEFRAG_MACVLAN);

		if (!skb)

			return RX_HANDLER_CONSUMED;

		eth = eth_hdr(skb);

		src = macvlan_hash_lookup(port, eth->h_source);

		if (!src)

			/* frame comes from an external address */