Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e0d8cc1 authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville
Browse files

bcma: signedness bug in bcma_get_next_core() 



The u32 would never be less than zero so the error handling would
break.  I changed it to s32 to match how bcma_erom_get_mst_port() is
declared.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 152e585d

drivers/bcma/scan.c

+1 −1
Original line number Diff line number Diff line
@@ -281,7 +281,7 @@ static int bcma_get_next_core(struct bcma_bus *bus, u32 __iomem **eromptr, 


	/* get & parse master ports */

	for (i = 0; i < ports[0]; i++) {

		u32 mst_port_d = bcma_erom_get_mst_port(bus, eromptr);

		s32 mst_port_d = bcma_erom_get_mst_port(bus, eromptr);

		if (mst_port_d < 0)

			return -EILSEQ;

	}