Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d2b2956 authored by Huang Ying's avatar Huang Ying Committed by Len Brown
Browse files

ACPI, APEI, HEST, Detect duplicated hardware error source ID 

The firmware on some machine will report duplicated hardware error
source ID in HEST.  This is considered a firmware bug.  To provide
better warning message, this patch adds duplicated hardware error
source ID detecting and corresponding printk.

This patch fixes #37412 on kernel bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=37412



Reported-by: default avatar <marconifabio@ubuntu-it.org>
Signed-off-by: default avatarHuang Ying <ying.huang@intel.com>
Tested-by: default avatarMathias <janedo.spam@gmail.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 8d86e5f9

drivers/acpi/apei/hest.c

+11 −1
Original line number Diff line number Diff line
@@ -139,13 +139,23 @@ static int __init hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data) 
{

	struct platform_device *ghes_dev;

	struct ghes_arr *ghes_arr = data;

	int rc;

	int rc, i;



	if (hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR)

		return 0;



	if (!((struct acpi_hest_generic *)hest_hdr)->enabled)

		return 0;

	for (i = 0; i < ghes_arr->count; i++) {

		struct acpi_hest_header *hdr;

		ghes_dev = ghes_arr->ghes_devs[i];

		hdr = *(struct acpi_hest_header **)ghes_dev->dev.platform_data;

		if (hdr->source_id == hest_hdr->source_id) {

			pr_warning(FW_WARN HEST_PFX "Duplicated hardware error source ID: %d.\n",

				   hdr->source_id);

			return -EIO;

		}

	}

	ghes_dev = platform_device_alloc("GHES", hest_hdr->source_id);

	if (!ghes_dev)

		return -ENOMEM;