Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d01d880 authored by Brian Norris's avatar Brian Norris Committed by Wolfram Sang
Browse files

i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer() 



cros_ec_cmd_xfer returns success status if the command transport
completes successfully, but the execution result is incorrectly ignored.
In many cases, the execution result is assumed to be successful, leading
to ignored errors and operating on uninitialized data.

We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
problems. Let's use it.

[Regarding the 'Fixes' tag; there is significant refactoring since the driver's
introduction, but the underlying logical error exists throughout I believe]

Fixes: 9d230c9e ("i2c: ChromeOS EC tunnel driver")
Cc: <stable@vger.kernel.org> # 9798ac6d mfd: cros_ec: Add cros_ec_cmd_xfer_status() helper
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Reviewed-by: default avatarJavier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent ce8cb803

drivers/i2c/busses/i2c-cros-ec-tunnel.c

+1 −1
Original line number Diff line number Diff line
@@ -215,7 +215,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[], 
	msg->outsize = request_len;

	msg->insize = response_len;



	result = cros_ec_cmd_xfer(bus->ec, msg);

	result = cros_ec_cmd_xfer_status(bus->ec, msg);

	if (result < 0) {

		dev_err(dev, "Error transferring EC i2c message %d\n", result);

		goto exit;