Commit 4d0197a5 authored Oct 13, 2015 by Dan Carpenter Committed by Mark Brown Oct 22, 2015

ASoC: wm8903: harmless underflow in wm8903_put_deemph()



Valid values for "deemph" are zero and one, but we accidentally allow
negative values as well.  It's harmless, but static checkers complain
and we may as well clean it up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 6ff33f39

sound/soc/codecs/wm8903.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -452,7 +452,7 @@ static int wm8903_put_deemph(struct snd_kcontrol *kcontrol,
		{
		struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
		struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
		int deemph = ucontrol->value.integer.value[0];
		unsigned int deemph = ucontrol->value.integer.value[0];
		int ret = 0;

		if (deemph > 1)