Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c817ccf authored by Vivek Gautam's avatar Vivek Gautam Committed by Thierry Reding
Browse files

soc/tegra: pmc: Use the new reset APIs to manage reset controllers 



Make use of of_reset_control_array_get_exclusive() to manage
an array of reset controllers available with the device.

Cc: Jon Hunter <jonathanh@nvidia.com>
Cc: Thierry Reding <treding@nvidia.com>
Signed-off-by: default avatarVivek Gautam <vivek.gautam@codeaurora.org>
[p.zabel@pengutronix.de: switch to hidden reset control array]
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Acked-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 507c655a

drivers/soc/tegra/pmc.c

+18 −74
Original line number Original line Diff line number Diff line
@@ -127,8 +127,7 @@ struct tegra_powergate { 
	unsigned int id;

	unsigned int id;

	struct clk **clks;

	struct clk **clks;

	unsigned int num_clks;

	unsigned int num_clks;

	struct reset_control **resets;

	struct reset_control *reset;

	unsigned int num_resets;

};

};





struct tegra_io_pad_soc {

struct tegra_io_pad_soc {
@@ -369,34 +368,6 @@ static int tegra_powergate_enable_clocks(struct tegra_powergate *pg) 
	return err;

	return err;

}

}





static int tegra_powergate_reset_assert(struct tegra_powergate *pg)

{

	unsigned int i;

	int err;



	for (i = 0; i < pg->num_resets; i++) {

		err = reset_control_assert(pg->resets[i]);

		if (err)

			return err;

	}



	return 0;

}



static int tegra_powergate_reset_deassert(struct tegra_powergate *pg)

{

	unsigned int i;

	int err;



	for (i = 0; i < pg->num_resets; i++) {

		err = reset_control_deassert(pg->resets[i]);

		if (err)

			return err;

	}



	return 0;

}



int __weak tegra210_clk_handle_mbist_war(unsigned int id)

int __weak tegra210_clk_handle_mbist_war(unsigned int id)

{

{

	return 0;

	return 0;
@@ -407,7 +378,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg, 
{

{

	int err;

	int err;





	err = tegra_powergate_reset_assert(pg);

	err = reset_control_assert(pg->reset);

	if (err)

	if (err)

		return err;

		return err;
@@ -431,7 +402,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg, 




	usleep_range(10, 20);

	usleep_range(10, 20);





	err = tegra_powergate_reset_deassert(pg);

	err = reset_control_deassert(pg->reset);

	if (err)

	if (err)

		goto powergate_off;

		goto powergate_off;
@@ -467,7 +438,7 @@ static int tegra_powergate_power_down(struct tegra_powergate *pg) 




	usleep_range(10, 20);

	usleep_range(10, 20);





	err = tegra_powergate_reset_assert(pg);

	err = reset_control_assert(pg->reset);

	if (err)

	if (err)

		goto disable_clks;

		goto disable_clks;
@@ -486,7 +457,7 @@ static int tegra_powergate_power_down(struct tegra_powergate *pg) 
assert_resets:

assert_resets:

	tegra_powergate_enable_clocks(pg);

	tegra_powergate_enable_clocks(pg);

	usleep_range(10, 20);

	usleep_range(10, 20);

	tegra_powergate_reset_deassert(pg);

	reset_control_deassert(pg->reset);

	usleep_range(10, 20);

	usleep_range(10, 20);





disable_clks:

disable_clks:
@@ -597,8 +568,7 @@ int tegra_powergate_sequence_power_up(unsigned int id, struct clk *clk, 
	pg.id = id;

	pg.id = id;

	pg.clks = &clk;

	pg.clks = &clk;

	pg.num_clks = 1;

	pg.num_clks = 1;

	pg.resets = &rst;

	pg.reset = rst;

	pg.num_resets = 1;

	pg.pmc = pmc;

	pg.pmc = pmc;





	err = tegra_powergate_power_up(&pg, false);

	err = tegra_powergate_power_up(&pg, false);
@@ -787,45 +757,22 @@ static int tegra_powergate_of_get_clks(struct tegra_powergate *pg, 
static int tegra_powergate_of_get_resets(struct tegra_powergate *pg,

static int tegra_powergate_of_get_resets(struct tegra_powergate *pg,

					 struct device_node *np, bool off)

					 struct device_node *np, bool off)

{

{

	struct reset_control *rst;

	unsigned int i, count;

	int err;

	int err;





	count = of_count_phandle_with_args(np, "resets", "#reset-cells");

	pg->reset = of_reset_control_array_get_exclusive(np);

	if (count == 0)

	if (IS_ERR(pg->reset)) {

		return -ENODEV;

		err = PTR_ERR(pg->reset);



		pr_err("failed to get device resets: %d\n", err);

	pg->resets = kcalloc(count, sizeof(rst), GFP_KERNEL);

		return err;

	if (!pg->resets)

		return -ENOMEM;



	for (i = 0; i < count; i++) {

		pg->resets[i] = of_reset_control_get_by_index(np, i);

		if (IS_ERR(pg->resets[i])) {

			err = PTR_ERR(pg->resets[i]);

			goto error;

	}

	}





	if (off)

	if (off)

			err = reset_control_assert(pg->resets[i]);

		err = reset_control_assert(pg->reset);

	else

	else

			err = reset_control_deassert(pg->resets[i]);

		err = reset_control_deassert(pg->reset);



		if (err) {

			reset_control_put(pg->resets[i]);

			goto error;

		}

	}



	pg->num_resets = count;



	return 0;



error:

	while (i--)

		reset_control_put(pg->resets[i]);





	kfree(pg->resets);

	if (err)

		reset_control_put(pg->reset);





	return err;

	return err;

}

}
@@ -917,10 +864,7 @@ static void tegra_powergate_add(struct tegra_pmc *pmc, struct device_node *np) 
	pm_genpd_remove(&pg->genpd);

	pm_genpd_remove(&pg->genpd);





remove_resets:

remove_resets:

	while (pg->num_resets--)

	reset_control_put(pg->reset);

		reset_control_put(pg->resets[pg->num_resets]);



	kfree(pg->resets);





remove_clks:

remove_clks:

	while (pg->num_clks--)

	while (pg->num_clks--)