Commit 4c628f3d authored Dec 21, 2015 by Linus Walleij

gpio: intel-mid: Be sure to clamp return value



As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Acked-by: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 8388f290

drivers/gpio/gpio-intel-mid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -120,7 +120,7 @@ static int intel_gpio_get(struct gpio_chip *chip, unsigned offset)
		{
		void __iomem *gplr = gpio_reg(chip, offset, GPLR);

		return readl(gplr) & BIT(offset % 32);
		return !!(readl(gplr) & BIT(offset % 32));
		}

		static void intel_gpio_set(struct gpio_chip *chip, unsigned offset, int value)