Commit 4c36941a authored Oct 07, 2016 by Christophe Jaillet Committed by Herbert Xu Oct 21, 2016

crypto: crypto4xx - Fix size used in dma_free_coherent()



The size used in 'dma_free_coherent()' looks un-initialized here.
ctx->sa_len is set a few lines below and is apparently not set by the
caller.
So use 'size' as in the corresponding 'dma_alloc_coherent()' a few lines
above.

This has been spotted with coccinelle, using the following script:
////////////////////
@r@
expression x0, x1, y0, y1, z0, z1, t0, t1, ret;
@@

*   ret = dma_alloc_coherent(x0, y0, z0, t0);
    ...
*   dma_free_coherent(x1, y1, ret, t1);

@script:python@
y0 << r.y0;
y1 << r.y1;

@@
if y1.find(y0) == -1:
 print "WARNING: sizes look different:  '%s'   vs   '%s'" % (y0, y1)
////////////////////

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent f34dad17

drivers/crypto/amcc/crypto4xx_core.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -135,8 +135,7 @@ int crypto4xx_alloc_sa(struct crypto4xx_ctx *ctx, u32 size)
		ctx->sa_out = dma_alloc_coherent(ctx->dev->core_dev->device, size * 4,
		&ctx->sa_out_dma_addr, GFP_ATOMIC);
		if (ctx->sa_out == NULL) {
		dma_free_coherent(ctx->dev->core_dev->device,
		ctx->sa_len * 4,
		dma_free_coherent(ctx->dev->core_dev->device, size * 4,
		ctx->sa_in, ctx->sa_in_dma_addr);
		return -ENOMEM;
		}