Commit 4c0e22c9 authored Nov 12, 2017 by Pierre Committed by Herbert Xu Nov 29, 2017

crypto: ecc - Fix NULL pointer deref. on no default_rng



If crypto_get_default_rng returns an error, the
function ecc_gen_privkey should return an error.
Instead, it currently tries to use the default_rng
nevertheless, thus creating a kernel panic with a
NULL pointer dereference.
Returning the error directly, as was supposedly
intended when looking at the code, fixes this.

Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent f7daa715

crypto/ecc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -964,7 +964,7 @@ int ecc_gen_privkey(unsigned int curve_id, unsigned int ndigits, u64 *privkey)
		* DRBG with a security strength of 256.
		*/
		if (crypto_get_default_rng())
		err = -EFAULT;
		return -EFAULT;

		err = crypto_rng_get_bytes(crypto_default_rng, (u8 *)priv, nbytes);
		crypto_put_default_rng();