Commit 4c0b92ed authored Dec 26, 2015 by Soren Brinkmann Committed by Greg Kroah-Hartman Feb 06, 2016

tty: xuartps: Keep lock for whole ISR



The RX path in the interrupt handler released a lock unnecessarily.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6e14f7c1

drivers/tty/serial/xilinx_uartps.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -265,9 +265,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
		uart_insert_char(port, isrstatus, CDNS_UART_IXR_OVERRUN,
		data, status);
		}
		spin_unlock(&port->lock);
		tty_flip_buffer_push(&port->state->port);
		spin_lock(&port->lock);
		}

		/* Dispatch an appropriate handler */