Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4ba988db authored by Andrew Vasquez's avatar Andrew Vasquez Committed by James Bottomley
Browse files

[SCSI] qla2xxx: Clear options-flags while issuing stop-firmware mbx command. 



Not clearing the options flags in mbx1 could lead the firmware
into interpreting old data in mbx1 through mbx8.  This could
lead to inadvertent DMA read/write operations to stale memory.

Signed-off-by: default avatarAndrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: default avatarChad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent d051a5aa

drivers/scsi/qla2xxx/qla_mbx.c

+2 −1
Original line number Diff line number Diff line
@@ -2581,7 +2581,8 @@ qla2x00_stop_firmware(scsi_qla_host_t *vha) 
	ql_dbg(ql_dbg_mbx, vha, 0x10a1, "Entered %s.\n", __func__);



	mcp->mb[0] = MBC_STOP_FIRMWARE;

	mcp->out_mb = MBX_0;

	mcp->mb[1] = 0;

	mcp->out_mb = MBX_1|MBX_0;

	mcp->in_mb = MBX_0;

	mcp->tov = 5;

	mcp->flags = 0;