Commit 4b1fb935 authored Apr 22, 2016 by Sabrina Dubroca Committed by David S. Miller Apr 24, 2016

macsec: fix netlink attribute validation



macsec_validate_attr should check IFLA_MACSEC_REPLAY_PROTECT (not
IFLA_MACSEC_PROTECT) to verify that the replay protection and replay
window arguments are correct.

Fixes: c09440f7 ("macsec: introduce IEEE 802.1AE driver")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 74816480

drivers/net/macsec.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3147,8 +3147,8 @@ static int macsec_validate_attr(struct nlattr tb[], struct nlattr data[])
		nla_get_u8(data[IFLA_MACSEC_VALIDATION]) > MACSEC_VALIDATE_MAX)
		return -EINVAL;

		if ((data[IFLA_MACSEC_PROTECT] &&
		nla_get_u8(data[IFLA_MACSEC_PROTECT])) &&
		if ((data[IFLA_MACSEC_REPLAY_PROTECT] &&
		nla_get_u8(data[IFLA_MACSEC_REPLAY_PROTECT])) &&
		!data[IFLA_MACSEC_WINDOW])
		return -EINVAL;