Commit 4ab4ba32 authored Sep 03, 2008 by Petr Tesarik Committed by Ingo Molnar Sep 05, 2008

x86, tracehook: clean up implementation of syscall_get_error()



The x86-tracehook code now contains this line in syscall_get_error():

	return error >= -4095L ? error : 0;

Hard-wiring a constant is not nice. Let's use the IS_ERR_VALUE macro
from linux/err.h instead.

Signed-off-by: Petr Tesarik <ptesarik@suse.cz>
Cc: utrace-devel@redhat.com
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 28c3cfd5

include/asm-x86/syscall.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -14,6 +14,7 @@
		#define _ASM_SYSCALL_H 1

		#include <linux/sched.h>
		#include <linux/err.h>

		static inline long syscall_get_nr(struct task_struct *task,
		struct pt_regs *regs)
		@@ -47,7 +48,7 @@ static inline long syscall_get_error(struct task_struct *task,
		*/
		error = (long) (int) error;
		#endif
		return error >= -4095L ? error : 0;
		return IS_ERR_VALUE(error) ? error : 0;
		}

		static inline long syscall_get_return_value(struct task_struct *task,