Commit 49393347 authored Jul 28, 2017 by stephen hemminger Committed by David S. Miller Jul 29, 2017

netvsc: fix error unwind on device setup failure



If setting receive buffer fails, the error unwind would cause
kernel panic because it was not correctly doing RCU and NAPI
unwind.  RCU'd pointer needs to be reset to NULL, and NAPI needs
to be disabled not deleted.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7426b1a5

drivers/net/hyperv/netvsc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1307,7 +1307,8 @@ struct netvsc_device netvsc_device_add(struct hv_device device,
		return net_device;

		close:
		netif_napi_del(&net_device->chan_table[0].napi);
		RCU_INIT_POINTER(net_device_ctx->nvdev, NULL);
		napi_disable(&net_device->chan_table[0].napi);

		/* Now, we can close the channel safely */
		vmbus_close(device->channel);