Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48e7a3c9 authored by Johannes Weiner's avatar Johannes Weiner Committed by Jiri Kosina
Browse files

HID: fix incorrect free in hiddev 



If hiddev_open() fails, it wrongly frees the shared hiddev structure
kept in hiddev_table instead of the hiddev_list structure allocated
for the opened file descriptor.  Existing references to this structure
will then accessed free memory.

This was introduced by 07903407 "HID: hiddev cleanup -- handle all
error conditions properly".

Signed-off-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Cc: Oliver Neukum <oliver@neukum.name>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent d2f8d7ee

drivers/hid/usbhid/hiddev.c

+1 −1
Original line number Diff line number Diff line
@@ -306,7 +306,7 @@ static int hiddev_open(struct inode *inode, struct file *file) 
	return 0;

bail:

	file->private_data = NULL;

	kfree(list->hiddev);

	kfree(list);

	return res;

}