Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4844f512 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: isight: use position offset macro of TLV data 



A series of SNDRV_CTL_TLVO_XXX macro was introduced for position offset
of TLV data. This commit applies a code optimization.

Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 51cdc8b6

sound/firewire/isight.c

+6 −4
Original line number Original line Diff line number Diff line
@@ -569,18 +569,20 @@ static int isight_create_mixer(struct isight *isight) 
		return err;

		return err;

	isight->gain_max = be32_to_cpu(value);

	isight->gain_max = be32_to_cpu(value);





	isight->gain_tlv[0] = SNDRV_CTL_TLVT_DB_MINMAX;

	isight->gain_tlv[SNDRV_CTL_TLVO_TYPE] = SNDRV_CTL_TLVT_DB_MINMAX;

	isight->gain_tlv[1] = 2 * sizeof(unsigned int);

	isight->gain_tlv[SNDRV_CTL_TLVO_LEN] = 2 * sizeof(unsigned int);





	err = reg_read(isight, REG_GAIN_DB_START, &value);

	err = reg_read(isight, REG_GAIN_DB_START, &value);

	if (err < 0)

	if (err < 0)

		return err;

		return err;

	isight->gain_tlv[2] = (s32)be32_to_cpu(value) * 100;

	isight->gain_tlv[SNDRV_CTL_TLVO_DB_MINMAX_MIN] =

						(s32)be32_to_cpu(value) * 100;





	err = reg_read(isight, REG_GAIN_DB_END, &value);

	err = reg_read(isight, REG_GAIN_DB_END, &value);

	if (err < 0)

	if (err < 0)

		return err;

		return err;

	isight->gain_tlv[3] = (s32)be32_to_cpu(value) * 100;

	isight->gain_tlv[SNDRV_CTL_TLVO_DB_MINMAX_MAX] =

						(s32)be32_to_cpu(value) * 100;





	ctl = snd_ctl_new1(&gain_control, isight);

	ctl = snd_ctl_new1(&gain_control, isight);

	if (ctl)

	if (ctl)